Added ability to set directory in pytorch lightning#581
Open
fishbotics wants to merge 2 commits intoreplicate:mainfrom
Open
Added ability to set directory in pytorch lightning#581fishbotics wants to merge 2 commits intoreplicate:mainfrom
fishbotics wants to merge 2 commits intoreplicate:mainfrom
Conversation
Signed-off-by: Adam Fishman <afishman@cs.washington.edu>
Author
|
When I run How should I change this to pass muster? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As its currently implemented, there's no great way to set the directory for the keepsake logs as it's hardcoded as "."
This makes it so that passing in a filepath with actually lead to the path being used, both for the directory and also for the specifickeepsake file.